add support for optional terms url #66
Draft
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkainz
approved these changes
Feb 23, 2021
|
Would this be viewable by clients? If so, then this request should be made to an internal site, right...? |
|
@jrobinson01 John, what's the current status of this PR? |
|
@tkainz It looks like we'd need to code for it on the client side, but I believe the original concern around linking on mobile has been aleviated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for how to handle a link to terms:
https://banno-jha.atlassian.net/browse/PROD-3243
edit: this is blocked until mobile apps have better support for linking