Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom heads #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Custom heads #3

wants to merge 3 commits into from

Conversation

Barleytree
Copy link
Owner

The cheeks are trouble.

Copy link

@Tatrabbit Tatrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I have a face/cheek rig that works fully, I can dive into test this now. I've decompiled ONI and re-built the Dupery dll from this branch, but without using the rig you're using, it's a lot harder for me to figure out how the cheeks are being troublesome. I've accepted your add on Steam, let's talk about this when you can. Right now I'm awake and available afternoon, through the night, to next morning Eastern Time

Accessorizer component3 = __instance.gameObject.GetComponent<Accessorizer>();

Accessory headAccessory = component3.GetAccessory(Db.Get().AccessorySlots.HeadShape);
string cheekHash = HashCache.Get().Get(headAccessory.symbol.hash).Replace("headshape", "cheek");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not yet able to inspect this, I'll DM you about it, but is this line correct? Does the hash string itself contain the substring "headshape"?

else if (id.StartsWith("eyes_"))
{
slot = Db.Get().AccessorySlots.Eyes;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's starting to be a lot of else if here, perhaps putting prefixes and the corresponding slot in a List<KeyValuePair> could make the code more readable as the number of accessories the mod can override continues to increase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants