Skip to content

Commit

Permalink
Enable MD linter in SuperLinter's workflow (magento#8357)
Browse files Browse the repository at this point in the history
  • Loading branch information
dshevtsov authored Dec 8, 2020
1 parent 947e1a6 commit b5586d5
Show file tree
Hide file tree
Showing 11 changed files with 16 additions and 23 deletions.
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/NEW_FEATURE.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,3 @@ Issues that do not comply with our Code of Conduct or do not contain enough info
Feel free to remove this section before creating this issue.
-->

6 changes: 1 addition & 5 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ on:
branches:
- master
- 2.*-develop
paths-ignore:
- '**.md'
- '**.html'
- '**.xml'

###############
# Set the Job #
Expand Down Expand Up @@ -54,4 +50,4 @@ jobs:
VALIDATE_ALL_CODEBASE: false
DEFAULT_BRANCH: master
VALIDATE_HTML: false
VALIDATE_MARKDOWN: false
MARKDOWN_CONFIG_FILE: .markdownlint.json
2 changes: 1 addition & 1 deletion _checks/html_check_hook.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
if url_ignore
url_ignore.push(jekyll_excludes_as_regex).flatten!.uniq!
else
checks_config['html-proofer'].merge!(url_ignore: jekyll_excludes_as_regex)
checks_config['html-proofer'][:url_ignore] = jekyll_excludes_as_regex
end

# Read configuration options for html-proofer
Expand Down
2 changes: 1 addition & 1 deletion src/cloud/cdn/configure-fastly.md
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ To update your DNS configuration for development:

- Use the Magento CLI to change the base URL for your store.

```
```bash
php bin/magento setup:store-config:set --base-url="https://mcstaging.your-domain.com/"
```

Expand Down
2 changes: 1 addition & 1 deletion src/cloud/live/site-launch-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ To update DNS configuration for site launch:

- Use the Magento CLI to change the base URL for your store.

```
```bash
php bin/magento setup:store-config:set --base-url="https://www.your-domain.com/"
```

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,3 @@ The new page layout displays in all `Layout` dropdowns.
On the storefront, there is a new footer for those pages that use the `3 Columns Double Footer` layout.

![Storefront two footers layout]({{ site.baseurl }}/common/images/fdg/custom_layout_footer_bottom.png)

1 change: 0 additions & 1 deletion src/guides/v2.3/install-gde/system-requirements.md
Original file line number Diff line number Diff line change
Expand Up @@ -163,4 +163,3 @@ There is a known issue with `xdebug` that can affect Magento installations or ac
[Elasticsearch]: {{page.baseurl}}/config-guide/elasticsearch/es-overview.html
[Elasticsearch PHP client]: https://github.com/elastic/elasticsearch-php
[RabbitMQ]: {{page.baseurl}}/config-guide/mq/rabbitmq-overview.html

Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@ Types of changes:

The approach of defining what each release should include was taken from [Semantic Versioning](https://semver.org/).

3-component version numbers
---------------------------
```text
X.Y.Z
| | |
| | +-- Backward Compatible changes (bug fixes)
| +---- Backward Compatible changes (new features)
+------ Backward Incompatible changes
```
3-component version numbers:

```text
X.Y.Z
| | |
| | +-- Backward Compatible changes (bug fixes)
| +---- Backward Compatible changes (new features)
+------ Backward Incompatible changes
```

### Z release

Expand Down
2 changes: 1 addition & 1 deletion src/guides/v2.4/release-notes/commerce-2-4-1.md
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,7 @@ We have fixed hundreds of issues in the Magento 2.4.1 core code.

<!--- ENGCOM-7193-->

*  `sales_clean_quotes` no longer loads all expired quotes at once. Previously, Magento failed with this fatal error because all expired quotes were loaded simultaneously: `PHP Fatal error: Allowed memory size of 2147483648 bytes exhausted (tried to allocate 20480 bytes) in /path/to/magento2/vendor/magento/framework/Model/AbstractModel.php on line 359`,
* `sales_clean_quotes` no longer loads all expired quotes at once. Previously, Magento failed with this fatal error because all expired quotes were loaded simultaneously: `PHP Fatal error: Allowed memory size of 2147483648 bytes exhausted (tried to allocate 20480 bytes) in /path/to/magento2/vendor/magento/framework/Model/AbstractModel.php on line 359`,

### CSS

Expand Down
2 changes: 1 addition & 1 deletion src/guides/v2.4/release-notes/open-source-2-4-1.md
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ _Fix submitted by Michał Derlatka in pull request [29256](https://github.com/ma

<!--- ENGCOM-7193-->

*  `sales_clean_quotes` no longer loads all expired quotes at once. Previously, Magento failed with this fatal error because all expired quotes were loaded simultaneously: `PHP Fatal error: Allowed memory size of 2147483648 bytes exhausted (tried to allocate 20480 bytes) in /path/to/magento2/vendor/magento/framework/Model/AbstractModel.php on line 359`,
* `sales_clean_quotes` no longer loads all expired quotes at once. Previously, Magento failed with this fatal error because all expired quotes were loaded simultaneously: `PHP Fatal error: Allowed memory size of 2147483648 bytes exhausted (tried to allocate 20480 bytes) in /path/to/magento2/vendor/magento/framework/Model/AbstractModel.php on line 359`,

### CSS

Expand Down
2 changes: 1 addition & 1 deletion src/marketplace/sellers/installation-and-varnish-tests.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ The Installation and Varnish tests complete the following checks:
- Verify ability to add the extension to the [Magento project](https://devdocs.magento.com/guides/v2.4/install-gde/install-quick-ref.html#get-the-magento-software) with [Composer](https://getcomposer.org/).
- After adding and enabling the extension, verify successful Magento installation.
- Verify that you can [compile Magento code](https://devdocs.magento.com/guides/v2.4/config-guide/cli/config-cli-subcommands-compiler.html).
- Verify that you can [deploy static content](https://devdocs.magento.com/guides/v2.4/config-guide/cli/config-cli-subcommands-static-view.html).
- Verify that you can [deploy static content](https://devdocs.magento.com/guides/v2.4/config-guide/cli/config-cli-subcommands-static-view.html).
- Verify that you can [enable Magento Production mode](https://devdocs.magento.com/guides/v2.4/config-guide/cli/config-cli-subcommands-mode.html).
- Check that you can [reindex all data](https://devdocs.magento.com/guides/v2.4/config-guide/cli/config-cli-subcommands-index.html) with the installed extension.

Expand Down

0 comments on commit b5586d5

Please sign in to comment.