EnumValue validation rule allows multiple flags for FlaggedEnums #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eger values only.
|
Please release this if you merge it, I need it. |
atymic
pushed a commit
to atymic/laravel-enum
that referenced
this pull request
Oct 11, 2020
…Sampo#137) * EnumValue validation rule allows multiple flags for FlaggedEnums, integer values only. * Fixed check for flagged enum class. * Allowed string representation for enum flags value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the validation for flagged enums. I would consider the current behaviour as undesired. This might impact someones code.