Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up settings script #2593

Closed
wants to merge 11 commits into from
Closed

Tidy up settings script #2593

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8ce4711
settings: use more standard printf(1p), replace grep(1p) with sed(1p)
trn1ty May 20, 2024
eb9ee54
settings: replace more instances of echo(1p) with printf(1p) per posix
trn1ty May 20, 2024
5fd4183
settings: fix ifs hack
trn1ty May 20, 2024
0eedd83
settings: turn for loop into a two-liner
trn1ty May 20, 2024
5f93dc7
settings: refresh: clean up ifs hack
trn1ty May 20, 2024
f1e8ac6
settings: fix errors in previous fixes
trn1ty May 20, 2024
46afad6
settings: fix revert ifs hack
trn1ty May 20, 2024
d7576bd
settings: wrap "$1" subcommands in a case
trn1ty May 20, 2024
66a2c9c
settings: help text on invalid usage
trn1ty May 20, 2024
a86e83f
settings: no help text on valid usage
trn1ty May 20, 2024
4ae5bc2
fix output bug
Botspot May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
settings: fix ifs hack
  • Loading branch information
@trn1ty
trn1ty committed May 20, 2024
commit 5fd4183a1ace2ac18fb9f408cff16365eaff7dfc
12 changes: 2 additions & 10 deletions settings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,21 +179,13 @@ output="$(printf '%s\n' "$output" | sed '/^$/d')"

echo "Output: ${output}EOO"

settings="$(ls "${DIRECTORY}/etc/setting-params" | tr '\n' '|')"

settingnumber=1

PREIFS="$IFS"
IFS='|'
for name in $settings
for setting in "$DIRECTORY"/etc/setting-params/*
do
curval="$(printf '%s\n' "$output" | sed -n "${settingnumber}p")"

printf 'Setting "%s" to "%s"' "$name" "$curval"
printf 'Setting "%s" to "%s"' "$setting" "$curval"
printf "$curval\n" >"$DIRECTORY/data/settings/$name"

settingnumber=$(printf '1 + %s\n' "$settingnumber" | bc)
done
IFS="$PREIFS"