fix NPE in weibocom#470

BoyceOne · Jan 11, 2018 · 7db1047 · 7db1047
1 parent 1aca375
commit 7db1047
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/motan-registry-consul/src/main/java/com/weibo/api/motan/registry/consul/ConsulRegistry.java b/motan-registry-consul/src/main/java/com/weibo/api/motan/registry/consul/ConsulRegistry.java
@@ -212,13 +212,13 @@ protected String discoverCommand(URL url) {
     }
 
     private ConcurrentHashMap<String, List<URL>> lookupServiceUpdate(String group) {
+        ConcurrentHashMap<String, List<URL>> groupUrls = new ConcurrentHashMap<String, List<URL>>();
         Long lastConsulIndexId = lookupGroupServices.get(group) == null ? 0 : lookupGroupServices.get(group);
         ConsulResponse<List<ConsulService>> response = lookupConsulService(group, lastConsulIndexId);
         if (response != null) {
             List<ConsulService> services = response.getValue();
             if (services != null && !services.isEmpty()
                     && response.getConsulIndex() > lastConsulIndexId) {
-                ConcurrentHashMap<String, List<URL>> groupUrls = new ConcurrentHashMap<String, List<URL>>();
                 for (ConsulService service : services) {
                     try {
                         URL url = ConsulUtils.buildUrl(service);
@@ -239,7 +239,7 @@ private ConcurrentHashMap<String, List<URL>> lookupServiceUpdate(String group) {
                 LoggerUtil.info(group + " no need update, lastIndex:" + lastConsulIndexId);
             }
         }
-        return null;
+        return groupUrls;
     }
 
     private String lookupCommandUpdate(String group) {