Skip to content

Commit

Permalink
docs: add comment about potential overflow of base fee per gas (parad…
Browse files Browse the repository at this point in the history
  • Loading branch information
fgimenez authored May 17, 2024
1 parent 9441d98 commit ac0a005
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions crates/rpc/rpc-types-compat/src/engine/payload.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ pub fn try_payload_v1_to_block(payload: ExecutionPayloadV1) -> Result<Block, Pay
gas_used: payload.gas_used,
timestamp: payload.timestamp,
mix_hash: payload.prev_randao,
// WARNING: It’s allowed for a base fee in EIP1559 to increase unbounded. We assume that
// it will fit in an u64. This is not always necessarily true, although it is extremelly
// unlikely not to be the case, a u64 maximum would have 2^64 which equates to 18 ETH per
// gas.
base_fee_per_gas: Some(
payload
.base_fee_per_gas
Expand Down

0 comments on commit ac0a005

Please sign in to comment.