Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing grid rows stores #15255

Merged
merged 22 commits into from
Dec 31, 2024
Merged

Typing grid rows stores #15255

merged 22 commits into from
Dec 31, 2024

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Dec 27, 2024

Description

Typing grid rows stores

Copy link

qa-wolf bot commented Dec 27, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Dec 27, 2024
@adrinr adrinr requested a review from aptkingston December 30, 2024 10:51
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the removal of code required for sorting and inline searching.

@adrinr adrinr force-pushed the typing/stores-grid-rows branch from ca64393 to 4f8f23c Compare December 30, 2024 21:35
@adrinr adrinr requested a review from aptkingston December 30, 2024 21:48
Base automatically changed from typing/stores-grid-scroll to master December 31, 2024 10:24
@adrinr adrinr enabled auto-merge December 31, 2024 10:25
@adrinr adrinr merged commit 92f92d2 into master Dec 31, 2024
20 checks passed
@adrinr adrinr deleted the typing/stores-grid-rows branch December 31, 2024 10:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants