-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing grid rows stores #15255
Merged
Merged
Typing grid rows stores #15255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
aptkingston
requested changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the removal of code required for sorting and inline searching.
packages/frontend-core/src/components/grid/stores/datasources/nonPlus.ts
Outdated
Show resolved
Hide resolved
packages/frontend-core/src/components/grid/stores/datasources/table.ts
Outdated
Show resolved
Hide resolved
packages/frontend-core/src/components/grid/stores/datasources/viewV2.ts
Outdated
Show resolved
Hide resolved
adrinr
force-pushed
the
typing/stores-grid-rows
branch
from
December 30, 2024 21:35
ca64393
to
4f8f23c
Compare
aptkingston
approved these changes
Dec 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typing grid rows stores