Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract componenterrors from client #15445

Merged
merged 25 commits into from
Feb 4, 2025
Merged

Extract componenterrors from client #15445

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
2537ee6
Validate required settings messages from builder
adrinr Jan 27, 2025
9f92f34
Add CTA on component error
adrinr Jan 27, 2025
a3e69b7
Merge branch 'master' into BUDI-9016/extract-componenterrors-from-client
adrinr Jan 27, 2025
a0fb2c8
Fix after merge
adrinr Jan 27, 2025
224e12f
Validate ancestors
adrinr Jan 27, 2025
29d9e3d
Fix text
adrinr Jan 27, 2025
729309f
Merge branch 'master' into BUDI-9016/extract-componenterrors-from-client
adrinr Jan 27, 2025
684cf27
Error CTA
adrinr Jan 27, 2025
582854c
Fix checking ancestors
adrinr Jan 28, 2025
5b3bd1a
Clean
adrinr Jan 28, 2025
c793bd8
Remove MissingRequired components from the client
adrinr Jan 28, 2025
59875b7
Clean types
adrinr Jan 28, 2025
99e3875
Merge branch 'master' into BUDI-9016/extract-componenterrors-from-client
adrinr Jan 28, 2025
232adee
Remove lint error
adrinr Jan 28, 2025
f5fade5
Clean
adrinr Jan 28, 2025
8f7e9dc
Merge branch 'master' into BUDI-9016/extract-componenterrors-from-client
adrinr Jan 30, 2025
5ecd4c8
Merge branch 'master' into BUDI-9016/extract-componenterrors-from-client
adrinr Jan 30, 2025
8848950
Merge branch 'master' into BUDI-9016/extract-componenterrors-from-client
adrinr Jan 31, 2025
141fc90
Remove unnecessary "in" checks
adrinr Jan 31, 2025
ea2b7b8
Move utils and types
adrinr Jan 31, 2025
9976bcf
Handle sections properly
adrinr Jan 31, 2025
1274593
Fix types
adrinr Jan 31, 2025
2a7d7d5
Merge branch 'master' into BUDI-9016/extract-componenterrors-from-client
adrinr Feb 3, 2025
2547852
Merge branch 'master' into BUDI-9016/extract-componenterrors-from-client
adrinr Feb 3, 2025
01f1fc6
Remove flag
adrinr Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove lint error
  • Loading branch information
@adrinr
adrinr committed Jan 28, 2025
commit 232adee0a816931752618e1626cff995aefcec88
1 change: 1 addition & 0 deletions packages/client/src/components/error-states/ComponentErrorState.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
<div class="component-placeholder" use:styleable={styles}>
<Icon name="Alert" color="var(--spectrum-global-color-static-red-600)" />
{#if errorMessage}
<!-- eslint-disable-next-line svelte/no-at-html-tags-->
{@html errorMessage.message}
<ComponentErrorStateCta error={errorMessage} />
{/if}
Expand Down
Loading