test for convert() flow

test/Base.sol

@@ -62,9 +62,15 @@ contract Base is Test {
         uint32 depositCount
     );
 
+    // copy of NativeConverterImpl.Convert
+    event Convert(address indexed from, address indexed to, uint256 amount);
+
     // copy of L1EscrowImpl.Deposit
     event Deposit(address indexed from, address indexed to, uint256 amount);
 
+    // copy of NativeConverterImpl.Migrate
+    event Migrate(uint256 amount);
+
     // copy of ZkMinterBurner.Withdraw
     event Withdraw(address indexed from, address indexed to, uint256 amount);
 

test/ConvertFlows.t.sol

@@ -0,0 +1,118 @@
+// SPDX-License-Identifier: UNLICENSED
+pragma solidity ^0.8.17;
+
+import {Base} from "./Base.sol";
+
+contract Convert is Base {
+    /// @notice Alice converts 1000 L2_WUSDC to L2_USDC for herself.
+    function testConvertsWrappedUsdcToNativeUsdc() public {
+        vm.selectFork(_l2Fork);
+        vm.startPrank(_alice);
+
+        // setup
+        uint256 wrappedBalance1 = _erc20L2Wusdc.balanceOf(_alice);
+
+        uint256 amount = _toUSDC(1000);
+        _erc20L2Wusdc.approve(address(_nativeConverter), amount);
+
+        // check that our convert event is emitted
+        vm.expectEmit(address(_nativeConverter));
+        emit Convert(_alice, _alice, amount);
+
+        // call convert
+        _nativeConverter.convert(_alice, amount);
+
+        // alice's L2_WUSDC balance decreased
+        uint256 wrappedBalance2 = _erc20L2Wusdc.balanceOf(_alice);
+        assertEq(wrappedBalance1 - wrappedBalance2, amount);
+
+        // alice's L2_USDC balance increased
+        assertEq(_erc20L2Usdc.balanceOf(_alice), amount);
+
+        // converter's L2_BWUSDC balance increased
+        assertEq(_erc20L2Wusdc.balanceOf(address(_nativeConverter)), amount);
+
+        _assertUsdcSupplyAndBalancesMatch();
+    }
+
+    /// @notice Alice converts 1000 L2_WUSDC to L2_USDC for Bob.
+    function testConvertsWrappedUsdcToNativeUsdcForAnotherAddress() public {
+        vm.selectFork(_l2Fork);
+        vm.startPrank(_alice);
+
+        // setup
+        uint256 wrappedBalance1 = _erc20L2Wusdc.balanceOf(_alice);
+
+        uint256 amount = _toUSDC(1000);
+        _erc20L2Wusdc.approve(address(_nativeConverter), amount);
+
+        // check that our convert event is emitted
+        vm.expectEmit(address(_nativeConverter));
+        emit Convert(_alice, _bob, amount);
+
+        // call convert
+        _nativeConverter.convert(_bob, amount);
+
+        // alice's L2_WUSDC balance decreased
+        uint256 wrappedBalance2 = _erc20L2Wusdc.balanceOf(_alice);
+        assertEq(wrappedBalance1 - wrappedBalance2, amount);
+
+        // bob's L2_USDC balance increased
+        assertEq(_erc20L2Usdc.balanceOf(_bob), amount);
+
+        // converter's L2_BWUSDC balance increased
+        assertEq(_erc20L2Wusdc.balanceOf(address(_nativeConverter)), amount);
+
+        _assertUsdcSupplyAndBalancesMatch();
+    }
+
+    /// @notice Alice approves a 500 L2_WUSDC spend but tries to convert 1000 L2_WUSDC.
+    function testRevertConvertWithInsufficientApproval() public {
+        vm.selectFork(_l2Fork);
+        vm.startPrank(_alice);
+
+        // setup
+        uint256 wrappedBalance1 = _erc20L2Wusdc.balanceOf(_alice);
+
+        uint256 approveAmount = _toUSDC(500);
+        uint256 convertAmount = _toUSDC(1000);
+        _erc20L2Wusdc.approve(address(_nativeConverter), approveAmount);
+
+        // call convert
+        vm.expectRevert();
+        _nativeConverter.convert(_alice, convertAmount);
+
+        // alice's L2_WUSDC balance didn't change
+        uint256 wrappedBalance2 = _erc20L2Wusdc.balanceOf(_alice);
+        assertEq(wrappedBalance1, wrappedBalance2);
+
+        // alice's L2_USDC balance didn't change
+        assertEq(_erc20L2Usdc.balanceOf(_alice), 0);
+
+        _assertUsdcSupplyAndBalancesMatch();
+    }
+
+    /// @notice Alice tries to convert 0 L2_WUSDC.
+    function testRevertConvertingZero() public {
+        vm.selectFork(_l2Fork);
+        vm.startPrank(_alice);
+
+        // try to convert 0 L2_WUSDC to L2_USDC
+        vm.expectRevert();
+        _nativeConverter.convert(_alice, 0);
+
+        _assertUsdcSupplyAndBalancesMatch();
+    }
+
+    /// @notice Alice tries to deposit 1000 L1_USDC to L1Escrow for address zero.
+    function testRevertConvertingForAddressZero() public {
+        vm.selectFork(_l2Fork);
+        vm.startPrank(_alice);
+
+        // try to convert 1000 L2_WUSDC for address 0
+        vm.expectRevert();
+        _nativeConverter.convert(address(0), _toUSDC(1000));
+
+        _assertUsdcSupplyAndBalancesMatch();
+    }
+}