Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes to make the debugger more flexible #140

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ekr-cfa
Copy link
Collaborator

@ekr-cfa ekr-cfa commented Dec 29, 2024

  • Add persistent state (mostly for rustyline support)
  • Have process_command() (formerly process_line()) return a string rather than try to write to T: Write.
  • Remove the mocks that were needed for testing because of the previous item

Copy link
Collaborator

@k88hudson-cfa k88hudson-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the population command no longer seems to be working

let args = shlex::split(l).ok_or("Error splitting lines")?;
let matches = self
.build_cli()
.cli
.clone()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth commenting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants