Allow to override task timeout for consumer class #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psrok1
approved these changes
Jan 22, 2025
psrok1
changed the title
|
@psrok1 It's better to add extra condition on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
While examining your
karton-corecode, I found karton.task_timeout config parameter (it also described in docs).Sometimes it could hard to use united timeout for services (for example, you expect 'karton-yara' to work at most 30 sec, and 'karton-drakvuf' at most 10 mins), so it's preferable to allow custom settings for each Consumer.
This PR introduces Consumer.task_timeout that this behaviour:
None- use global value described in config file.0- disable global-set task timeout.