Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC2023 - ACVD for Simplification & Remeshing #7837

Open
wants to merge 152 commits into
base: master
Choose a base branch
from

Conversation

hoskillua
Copy link
Member

@hoskillua hoskillua commented Oct 31, 2023

Release Management

TODO

  • remove commit introducing interpolated_corrected_curvatures.h after the merge of the gsoc2022 branch
  • remove qem_metrics.h and types.h from history (for @sloriot)
  • check branch size (for @sloriot)
  • handle interpolated curvature update (for @sloriot)
  • debug the QEM minimization implementation (for @hoskillua)
  • test the other versions as possibly some cases produce bad results (for @hoskillua)
  • code cleanup (especially the logic for computing energy difference on edge and moving an element for @hoskillua )
  • recompute the energy after each convergence (for @hoskillua)
  • add concurrency flag (optional @sloriot)
  • better initialisation
  • test ACVD remeshing
  • deal with the subdivision code
  • Small feature for the subdivison code
  • get rid of duplicated implementation (keep only qem one)

}


std::vector<std::size_t> one_ring;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reserve() ?

@@ -120,6 +118,13 @@ void CatmullClark_subdivision(PolygonMesh& pmesh, int step) {
* \cgalParamType{unsigned int}
* \cgalParamDefault{`1`}
* \cgalParamNEnd
* \cgalParamNBegin{do_not_modify_geometry}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that the default was true and that the named parameter is just modify_geometry().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants