-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSoC2023 - ACVD for Simplification & Remeshing #7837
Open
hoskillua
wants to merge
152
commits into
CGAL:master
Choose a base branch
from
hoskillua:gsoc2023
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afabri
reviewed
Oct 31, 2023
...gon_mesh_processing/include/CGAL/Polygon_mesh_processing/interpolated_corrected_curvatures.h
Outdated
Show resolved
Hide resolved
afabri
reviewed
Oct 31, 2023
...gon_mesh_processing/include/CGAL/Polygon_mesh_processing/interpolated_corrected_curvatures.h
Outdated
Show resolved
Hide resolved
afabri
reviewed
Oct 31, 2023
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/acvd/acvd.h
Outdated
Show resolved
Hide resolved
afabri
reviewed
Oct 31, 2023
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/acvd/acvd.h
Outdated
Show resolved
Hide resolved
need to clean up code
afabri
reviewed
Mar 3, 2025
...ing/include/CGAL/Polygon_mesh_processing/approximated_centroidal_Voronoi_diagram_remeshing.h
Outdated
Show resolved
Hide resolved
afabri
reviewed
Mar 3, 2025
...ing/include/CGAL/Polygon_mesh_processing/approximated_centroidal_Voronoi_diagram_remeshing.h
Show resolved
Hide resolved
afabri
reviewed
Mar 3, 2025
...ing/include/CGAL/Polygon_mesh_processing/approximated_centroidal_Voronoi_diagram_remeshing.h
Show resolved
Hide resolved
afabri
reviewed
Mar 3, 2025
...ing/include/CGAL/Polygon_mesh_processing/approximated_centroidal_Voronoi_diagram_remeshing.h
Show resolved
Hide resolved
afabri
reviewed
Mar 3, 2025
...ing/include/CGAL/Polygon_mesh_processing/approximated_centroidal_Voronoi_diagram_remeshing.h
Outdated
Show resolved
Hide resolved
afabri
reviewed
Mar 3, 2025
...ing/include/CGAL/Polygon_mesh_processing/approximated_centroidal_Voronoi_diagram_remeshing.h
Show resolved
Hide resolved
afabri
reviewed
Mar 3, 2025
...ing/include/CGAL/Polygon_mesh_processing/approximated_centroidal_Voronoi_diagram_remeshing.h
Show resolved
Hide resolved
afabri
reviewed
Mar 3, 2025
} | ||
|
||
|
||
std::vector<std::size_t> one_ring; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reserve()
?
As to support fixed subdivsion for quad meshes
use the NP in Loop / Catmull-Clark instead
afabri
reviewed
Mar 17, 2025
Subdivision_method_3/doc/Subdivision_method_3/Subdivision_method_3.txt
Outdated
Show resolved
Hide resolved
afabri
reviewed
Mar 17, 2025
Subdivision_method_3/doc/Subdivision_method_3/Subdivision_method_3.txt
Outdated
Show resolved
Hide resolved
afabri
reviewed
Mar 17, 2025
@@ -120,6 +118,13 @@ void CatmullClark_subdivision(PolygonMesh& pmesh, int step) { | |||
* \cgalParamType{unsigned int} | |||
* \cgalParamDefault{`1`} | |||
* \cgalParamNEnd | |||
* \cgalParamNBegin{do_not_modify_geometry} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer that the default was true
and that the named parameter is just modify_geometry()
.
afabri
reviewed
Mar 17, 2025
Subdivision_method_3/test/Subdivision_method_3/test_Subdivision_method_3.cpp
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CHANGES.md not updated
gsoc
gsoc-2023
Pkg::PMP
pre-approved
For pre-approved small features. After 15 days the feature will be accepted.
Ready to be tested
Small feature
TODO
Under Testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Management
TODO
interpolated_corrected_curvatures.h
after the merge of the gsoc2022 branchqem_metrics.h
andtypes.h
from history (for @sloriot)