New package: Frechet Distance #8284
Conversation
|
|
||
| // Added to be similar to CGAL::Filtered_kernel | ||
| typedef EK Exact_kernel; | ||
| enum { Has_filtered_predicates = true }; | ||
| typedef Boolean_tag<Has_filtered_predicates> Has_filtered_predicates_tag; | ||
|
|
There was a problem hiding this comment.
As I said elsewhere, if that's really all that's needed (there is an example so I assume it compiles and runs, although I am rather surprised), ok.
(I would have mentioned in the comment the name of the package that needs it, but I guess this comment is good enough)
There was a problem hiding this comment.
Why are you surprised that it compiles?
There was a problem hiding this comment.
There have been a number of changes since then (I think other pieces were missing at the time), so the comment may not be relevant anymore.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
MaelRL
added
Not yet approved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@sloriot can you help me with this error with VC2017 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
| { | ||
| if constexpr (Approximate_traits::Dimension::value<=3) | ||
| { | ||
| // TODO: this assumes that input interval are all tight --> need a PM! |
There was a problem hiding this comment.
@sloriot can we discuss that please
| } | ||
| else | ||
| { | ||
| //TODO: not implemented |
There was a problem hiding this comment.
@anusser do we have to do something or is the next line what is done ?
There was a problem hiding this comment.
I honestly don't know exactly what's going on there. We can have a call if you want to discuss this directly.
| int main() | ||
| { | ||
| Curves curves; | ||
| #if 0 |
Co-authored-by: Mael <[email protected]>
Co-authored-by: Mael <[email protected]>
|
/build:v2 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v2/Manual/index.html |
Summary of Changes
Add a new package computing the approximate Fréchet distance between two polylines in dD under Euclidean metric, or decides if the distance is smaller than a given value.
Release Management
TODO:
Epick_d<Dimension_tag<2>>@sloriot