Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore coherent orientation of faces #8791

Merged
merged 1 commit into from
Mar 24, 2025
Merged

restore coherent orientation of faces #8791

merged 1 commit into from
Mar 24, 2025

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented Mar 20, 2025

This has been broken in 6.0

@MaelRL MaelRL modified the milestone: 6.0.2 Mar 20, 2025
@MaelRL
Copy link
Member

MaelRL commented Mar 20, 2025

should it target 6.0.2, then?

@sloriot sloriot changed the base branch from master to 6.0.x-branch March 20, 2025 10:04
@sloriot
Copy link
Member Author

sloriot commented Mar 20, 2025

should it target 6.0.2, then?

was the case, did not pick the right base when creating the PR. Fixed. Thanks.

@MaelRL MaelRL added this to the 6.0.2 milestone Mar 20, 2025
@MaelRL MaelRL requested a review from janetournois March 22, 2025 09:58
@MaelRL MaelRL changed the title restore coherant orientation of faces restore coherent orientation of faces Mar 24, 2025
@sloriot
Copy link
Member Author

sloriot commented Mar 24, 2025

Successfully tested in CGAL-6.1-Ic-114

@sloriot sloriot merged commit bcdd46a into CGAL:6.0.x-branch Mar 24, 2025
8 checks passed
@sloriot sloriot deleted the Mesh_3-orientation_of_out_faces branch March 24, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetournois janetournois Awaiting requested review from janetournois

Assignees
No one assigned
Labels
Bug Pkg::Mesh_3 Pkg::SMDS_3 Tested
Projects
None yet
Milestone
6.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@sloriot @MaelRL