Add Float 2d snap rounding #8797
Conversation
…ficient subdivision of segments by vertices
| }; | ||
|
|
||
| // Generic template signature of boxes, specialized for ID_FROM_HANDLE policy | ||
| #if 0 |
| #define CGAL_FLOAT_SNAP_ROUNDING_2_H | ||
|
|
||
|
|
||
| #include <iostream> |
| } | ||
|
|
||
| template <class PointsRange , class PolylineRange> | ||
| void double_snap_rounding_2_disjoint(PointsRange &pts, |
| PolylineRange &polylines) | ||
| { | ||
| using Point_2 = std::remove_cv_t<typename std::iterator_traits<typename PointsRange::iterator>::value_type>; | ||
| using Kernel = typename Kernel_traits<Point_2>::Kernel; |
There was a problem hiding this comment.
does it make sense to have named parameters for the traits? + point map maybe? Also we will need a traits concept with all the requirements of the function
There was a problem hiding this comment.
If the traits is a parameter you won't a point map (can be integrated in a model of the concept of the traits), so no NP for now I'd say.
| using PBox = CGAL::Box_intersection_d::Box_with_index_d<double,2>; | ||
| using SBox = CGAL::Box_intersection_d::Box_with_index_d<double,2>; | ||
|
|
||
| auto comp_by_x=[&](size_t ai, size_t bi){ |
There was a problem hiding this comment.
size_t -> std::size_t everywhere
| auto comp_by_x=[&](size_t ai, size_t bi){ | ||
| return compare(pts[ai].x(),pts[bi].x())==SMALLER; | ||
| }; | ||
| auto comp_by_y=[&](size_t ai, size_t bi){ |
There was a problem hiding this comment.
You can use Less_x_2, Less_y_2 and Less_xy_2, part of your new concept ;)
| std::set<size_t, decltype(comp_by_y_first)> p_sort_by_y(comp_by_y_first); | ||
| for(size_t i=0; i!=pts.size(); ++i) | ||
| { | ||
| p_sort_by_x.insert(i); |
There was a problem hiding this comment.
what about using std::vector + std::iota + std::sort?
| for(size_t i=0; i<pts.size(); ++i) | ||
| points_boxes.emplace_back(pts[i].bbox(),i); | ||
| for(size_t i=0; i<polylines.size(); ++i) | ||
| segs_boxes.emplace_back(pts[polylines[i][0]].bbox()+pts[polylines[i][1]].bbox(),i); |
There was a problem hiding this comment.
use Construct_source_2 and Construct_target_2
|
|
||
| // Bound the maximum squared distance between a point and its rounded value | ||
| auto round_bound=[](Point_2& p){ | ||
| return std::pow(std::nextafter(p.x().approx().sup(),std::numeric_limits<double>::infinity())-p.x().approx().inf(),2)+ |
| #ifdef DOUBLE_2D_SNAP_VERBOSE | ||
| std::cout << points_boxes.size()-size_before << " subdivisions performed" << std::endl; | ||
| #endif | ||
| for(size_t i=size_before; i<pts.size(); ++i) |
|
Also, I think the user will be interested in having a correspondence between input and output segments |
Please use the following template to help us managing pull requests.
Summary of Changes
Add to function that given a range of segments, round their coordinates to double while preserving the topology
up to collapsedouble_snap_rounding_2output a range of Polyline corresponding to the input segmentscompute_snapped_subcurves_2output a range of segmentsRelease Management