Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suppress futile RuntimeWarnings from xarray #742

Closed
wants to merge 7 commits into from
Closed

suppress futile RuntimeWarnings from xarray #742

wants to merge 7 commits into from

Conversation

emanuel-schmid
Copy link
Collaborator

@emanuel-schmid emanuel-schmid commented Jun 30, 2023 •
edited
Loading

Changes proposed in this PR:

  • suppress specific warnings in write_hdf5 and from_hdf5

This PR fixes petals #84

PR Author Checklist

PR Reviewer Checklist

@emanuel-schmid emanuel-schmid requested a review from tovogt June 30, 2023 14:50
@emanuel-schmid emanuel-schmid mentioned this pull request Jun 30, 2023
Open
@emanuel-schmid emanuel-schmid marked this pull request as draft July 3, 2023 07:44
@peanutfun
Copy link
Member

@tovogt @emanuel-schmid Do we still need to suppress these warnings?

@tovogt
Copy link
Collaborator

tovogt commented Nov 1, 2023

At least, they will be gone in the latest version of xarray (soonish): pydata/xarray#7827

@peanutfun
Copy link
Member

Then I would be in favor of closing this PR and keeping track of the xarray bugfix in CLIMADA-project/climada_petals#84

@emanuel-schmid emanuel-schmid deleted the feature/suppress_xarray_cast_warnings branch November 8, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tovogt tovogt Awaiting requested review from tovogt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emanuel-schmid @peanutfun @tovogt