Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more Unit and CI tests #9

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Add more Unit and CI tests #9

merged 4 commits into from
Feb 21, 2024

Conversation

tmnp19
Copy link
Collaborator

@tmnp19 tmnp19 commented Feb 16, 2024

No description provided.

ruicoelhopedro
ruicoelhopedro reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@ruicoelhopedro ruicoelhopedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go! I found some places missing a newline at the end.
Also, the failing test needs to be checked as well, which should be quick.

test/examples/min_script.py Show resolved Hide resolved
test/test_examples_plots_assertions.py Show resolved Hide resolved
test/test_init_shot.py Show resolved Hide resolved
test/test_solver_utils.py Show resolved Hide resolved
@ruicoelhopedro ruicoelhopedro merged commit 7f84ddd into main Feb 21, 2024
7 checks passed
@ruicoelhopedro ruicoelhopedro deleted the ci_tests branch February 21, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruicoelhopedro ruicoelhopedro ruicoelhopedro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmnp19 @ruicoelhopedro