-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add video call feature in code room #21
Conversation
526c8a9
to
d9c3c25
Compare
12b49d8
to
05d95f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Video chat function looks v cool!
However I'm getting this error when I denied mic and camera permissions, maybe we could handle that and display a toast/prompts to allow users to update permissions instead?
I also got this other error when I exit out of a code room and enter another matched room for the second time
@fannyjian hmmm i could not replicate the permission error, on my side when i deny permission it will simply not show up... but lemme add some error boundary for that for the second error i'll be pushing a fix for that! edit: both should be fixed now, can you try it on ur side? :) |
05d95f5
to
72ef42f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Works perfect now:D
72ef42f
to
8513ec9
Compare
implement video call with agora RTC SDK
to use it, either sign up for an account at https://console.agora.io/ or use the following values in
.env.local
: