Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add video call feature in code room #21

Merged
merged 5 commits into from
Nov 14, 2023
Merged

add video call feature in code room #21

merged 5 commits into from
Nov 14, 2023

Conversation

david-eom
Copy link
Contributor

@david-eom david-eom commented Nov 13, 2023

implement video call with agora RTC SDK
to use it, either sign up for an account at https://console.agora.io/ or use the following values in .env.local:

NEXT_PUBLIC_AGORA_APP_ID="07a3b6e024c94596ae016c0bb2646e38"
NEXT_PUBLIC_AGORA_APP_CERTIFICATE="201827a36cb44e3c9086019cca1eaa48"

@david-eom david-eom force-pushed the video-call branch 6 times, most recently from 526c8a9 to d9c3c25 Compare November 13, 2023 15:19
@david-eom david-eom changed the title [WIP] add video call feature in code room add video call feature in code room Nov 13, 2023
@david-eom david-eom marked this pull request as ready for review November 14, 2023 03:29
Copy link
Contributor

@fannyjian fannyjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Video chat function looks v cool!

However I'm getting this error when I denied mic and camera permissions, maybe we could handle that and display a toast/prompts to allow users to update permissions instead?

Screenshot 2023-11-14 at 11 38 14 AM

I also got this other error when I exit out of a code room and enter another matched room for the second time

Screenshot 2023-11-14 at 11 38 42 AM

@david-eom
Copy link
Contributor Author

david-eom commented Nov 14, 2023

@fannyjian hmmm i could not replicate the permission error, on my side when i deny permission it will simply not show up... but lemme add some error boundary for that

for the second error i'll be pushing a fix for that!

edit: both should be fixed now, can you try it on ur side? :)

Copy link
Contributor

@fannyjian fannyjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works perfect now:D

@david-eom david-eom merged commit 1792952 into master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants