[ticket/14486] Use empty() and move error check.

PHPBB3-14486
CafeKeon · Feb 27, 2016 · 40bd4c8 · 40bd4c8
1 parent 4b4584b
commit 40bd4c8
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/phpBB/includes/functions.php b/phpBB/includes/functions.php
@@ -2848,7 +2848,7 @@ function login_box($redirect = '', $l_explain = '', $l_success = '', $admin = fa
 		trigger_error('NO_AUTH_ADMIN');
 	}
 
-	if (($request->is_set_post('login') || ($request->is_set('login') && $request->variable('login', '') == 'external')) && !$err)
+	if (empty($err) && ($request->is_set_post('login') || ($request->is_set('login') && $request->variable('login', '') == 'external')))
 	{
 		// Get credential
 		if ($admin)