Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sabaki.json #600

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Zim-the-Vixen
Copy link

@Zim-the-Vixen Zim-the-Vixen commented Mar 26, 2022

Sabaki serves as a go board and is a popular tool among go players.
We are not entirely sure if the autoupdate section works and would like to ask a sanity check on it. When we try to run checkver.ps1 sabaki <dir> -u on an older version we get ERROR You cannot call a method on a null-valued expression. Don't know what to make of it.

What package release type is this?

  • stable
  • I have read the Contributing Guide.
  • properly named and capitalized shortcuts?
  • autoupdate and checkver entry
  • a pre_install script to auto-enable portable mode (if needed)?
  • license identifier and url
  • a short terse description matching existing style.
  • url to the release along with its sha256 hash No hash available
  • bin entry for main binary
  • passes bin/checkver.ps1 and bin/checkurls.ps1
  • tested install, checked persist, no errors.
  • manifest is sorted to spec
  • manifest follows spec: appname or appname-variant (e.g citra-canary or dolphin-dev)
  • [] I tested the package and it runs in portable mode. I have verified the symlinks are correct in the persist folder and working.
  • I will maintain this manifest and promptly fix it in the event it breaks.

Sabaki serves as a go board and is a popular tool among go players.
We are not entirely sure if the autoupdate section works and would like to ask a sanity check on it. When  we try to run `checkver.ps1 sabaki <dir> -u` on an older version we get `ERROR You cannot call a method on a null-valued expression.` Don't know what to make of it.
@Calinou Calinou added the new package A package should be added label Mar 26, 2022
Comment on lines +10 to +15
"installer": {
"script": [
"try {7z x \"$dir\\`$PLUGINSDIR\\app-64.7z\" -o\"$dir\"}",
"catch {Write-Error \"7Zip needs to be in the path\"; exit 1}"
]
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why is this installer script needed? Scoop can handle unzipping with 7-zip as long as it's already installed and present in the PATH.

@superusercode
Copy link
Contributor

/verify

@github-actions
Copy link
Contributor

Your changes do not pass checks.

sabaki

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manifest-fix-needed new package A package should be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants