Show an error if the command fails to spawn #286
Merged
+11
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, bacon showed no output at all if spawning failed. Now, it gives a useful error instead:
```
Error: error in computation for job 'run'
Caused by:
0: failed to spawn cd "../example" && CARGO_TERM_COLOR="always" RUST_BACKTRACE="0" "./run.sh"
1: Exec format error (os error 8)
```
To test this, you can create a bacon.toml with `jobs.run.command = ["/not/here"]` and execute `bacon run`.
If a command fails, we failed to parse it. So our normal heuristic about whether to hide or show lines aren't applicable, and we should just always show it.
|
This is indeed much better. |
|
it's ready, if i make more changes i'll add them in followups. i noticed that the "run" output is often hidden if the command succeeds, because it doesn't trigger the case in my second commit and it doesn't look like cargo output. but if i change that i'll fix that in a followup, not here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, bacon showed no output at all if spawning failed. Now, it gives a useful error instead:
To test this, you can create a bacon.toml with
jobs.run.command = ["/not/here"]and executebacon run.