Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SUNDIALS 7.x compatibility/library list checks #1828

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

speth
Copy link
Member

@speth speth commented Dec 16, 2024

Changes proposed in this pull request

  • Correct SUNDIALS version checks so sundials_core is linked for SUNDIALS 7.0 and newer, and the warning about being untested only occurs for versions newer than 7.2.0.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.54%. Comparing base (1ef52c9) to head (0b53509).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1828      +/-   ##
==========================================
- Coverage   73.54%   73.54%   -0.01%     
==========================================
  Files         383      383              
  Lines       54653    54653              
  Branches     9105     9105              
==========================================
- Hits        40197    40194       -3     
- Misses      11458    11460       +2     
- Partials     2998     2999       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@speth speth requested a review from bryanwweber December 16, 2024 22:40
@speth speth merged commit 6e00275 into Cantera:main Dec 16, 2024
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants