-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dist ref kl #529
Open
Dahoas
wants to merge
27
commits into
main
Choose a base branch
from
dist-ref-kl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dist ref kl #529
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
f04446d
Implementing support for dense rewards
Dahoas 13a01fc
added "num_return_sequences" param which corresponds to n in Best-of-…
SharathRaparthy 5421a73
updates to "num_return_sequences" param
SharathRaparthy 2f3ac28
BoN implementation
SharathRaparthy 2f1dace
Changed back to default.
SharathRaparthy f58170d
TopK sampling instead of Top1
SharathRaparthy be8bc1a
summed along dim=1
SharathRaparthy 608d812
Generating samples in chunks
SharathRaparthy d8557e7
added gen_chunk_size parameter
SharathRaparthy 8ef9c36
chunking in forward prop
SharathRaparthy 4c1d82d
chunking generations in train and eval
SharathRaparthy ecd5107
Implementing support for dense rewards
Dahoas 4071604
Fix distributed ref_mean, ref_var bug for dense rewards
Dahoas 5f41413
Make generation respect max seq length
Dahoas 22ae83f
Make experience before first round of training
Dahoas 7d0a4be
Refactoring .generate/.generate_eval
Dahoas b79dd19
Fix BoN metric support
Dahoas cb49dc5
Enforce chunk_size param for eval generation when present
Dahoas e290412
Fix: Don't shuffle prompt dataset
Dahoas 391d04c
Move inputs to device
Dahoas 8de84e4
Fix style
Dahoas 404ef14
Fix: Do not shuffle empty experience dataloader
Dahoas 67b711a
Make experience before first round of training
Dahoas 34e185a
Refactoring .generate/.generate_eval
Dahoas 11e1e95
Refactored decode, make_experience and added support for external ref…
Dahoas 527ba23
Fix BoN sampling after big refactor
Dahoas 676a1cd
Fixing style
Dahoas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make experience before first round of training
- Loading branch information
commit 22ae83f5e1ffd96a0afb8eddf440bf4f6340d13c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in line 472 sample_outputs not assigned yet, seems
sample_outputs = pad_sequence(tok_outputs)