chore(db): create index on created_at for user_completions (TabbyML#1789

) * chore(db): Create index on created_at for user_completions * Apply suggestion * Reorder index fields * Apply suggestion * Move migration * Fix conflicts
CatsPunch · Apr 9, 2024 · d6130c2 · d6130c2
1 parent d6020e8
commit d6130c2
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 1 deletion.
diff --git a/ee/tabby-db/migrations/0023_user-completions-created-at-index.down.sql b/ee/tabby-db/migrations/0023_user-completions-created-at-index.down.sql
@@ -0,0 +1 @@
+DROP INDEX idx_user_completion_user_id_created_at_language;
diff --git a/ee/tabby-db/migrations/0023_user-completions-created-at-index.up.sql b/ee/tabby-db/migrations/0023_user-completions-created-at-index.up.sql
@@ -0,0 +1,2 @@
+DROP INDEX user_completions_user_id_language_idx;
+CREATE INDEX idx_user_completion_user_id_created_at_language ON user_completions(user_id, created_at, language);
diff --git a/ee/tabby-db/schema.sqlite b/ee/tabby-db/schema.sqlite
diff --git a/ee/tabby-db/src/user_completions.rs b/ee/tabby-db/src/user_completions.rs
@@ -67,7 +67,6 @@ impl DbConn {
         Ok(())
     }
 
-    // FIXME(boxbeam): index `created_at` in user_completions table.
     pub async fn compute_daily_stats_in_past_year(
         &self,
         users: Vec<i64>,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		DROP INDEX idx_user_completion_user_id_created_at_language;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		DROP INDEX user_completions_user_id_language_idx;
		CREATE INDEX idx_user_completion_user_id_created_at_language ON user_completions(user_id, created_at, language);
-Original file line number
+Diff line change
@@ Expand Up / @@ -67,7 +67,6 @@ impl DbConn { @@
             Ok(())
         }
-        // FIXME(boxbeam): index `created_at` in user_completions table.
         pub async fn compute_daily_stats_in_past_year(
             &self,
             users: Vec<i64>,
@@ Expand Down @@