Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6569] | root folder issue fix #199

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

sh-andriy
Copy link
Collaborator

ENG-6569 root folder issue fix

@sh-andriy sh-andriy requested a review from opaduchak January 3, 2025 09:50
Comment on lines 157 to 160
if subpath == "/":
folder_path = ""
else:
folder_path = subpath.strip("/")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this if statement is unnecessary

@sh-andriy sh-andriy requested a review from opaduchak January 3, 2025 10:00
Copy link
Collaborator

@opaduchak opaduchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adlius adlius merged commit 9b5b240 into CenterForOpenScience:develop Jan 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants