group cannot override dict.__iter__: now returns list of keys, not li…

…st of tasks. Closes celery#3688
Chris7 · Dec 15, 2016 · 8c7ac5d · 8c7ac5d
1 parent 199cf69
commit 8c7ac5d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/celery/canvas.py b/celery/canvas.py
@@ -1123,9 +1123,6 @@ def _freeze_unroll(self, new_tasks, group_id, chord, root_id, parent_id):
                                   chord=chord, root_id=root_id,
                                   parent_id=parent_id)
 
-    def __iter__(self):
-        return iter(self.tasks)
-
     def __repr__(self):
         if self.tasks:
             return remove_repeating_from_task(

diff --git a/t/unit/tasks/test_canvas.py b/t/unit/tasks/test_canvas.py
@@ -534,7 +534,7 @@ def test_skew(self):
 
     def test_iter(self):
         g = group([self.add.s(i, i) for i in range(10)])
-        assert list(iter(g)) == g.tasks
+        assert list(iter(g)) == list(g.keys())
 
     @staticmethod
     def helper_test_get_delay(result):