Click house/v1.56.3 #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These checks have not been needed since way back in #22100, but they were never removed, and they've even propagated to a bunch of new policies via copy-paste.
Third-party loggers will be added in subsequent PRs once the logger factory APIs are available to validate the configs here. This registry is used in `xds_http_rbac_filter.cc` to generate service config json.
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> --------- Co-authored-by: ctiller <[email protected]>
…935) Fix: grpc/grpc#18075 From comments in grpc/grpc#18075, `CPython` reinitialize the `GIL` after `pthread_atfork` child handler, thus we shouldn't use any `GIL` related functions in child handler which is what we're currently doing, this PR uses `os.register_at_fork` to replace `pthread_atfork` to prevent any undesired bevahior. This also seems to fixes a thread hanging issue cased by changes in core: grpc/grpc#32869 ### Testing: * Passed existing fork tests. (Note that due to some issues in `Bazel`, this change was not verified by `Bazel runs_per_test`). * Tested by patch the core PR, was able to fix Python fork tests: grpc/grpc#32933
To fix the timeout of protobuf-at-head test, we may want to reduce the test-load of these tests but let's fix the breakage first.
To get google/libprotobuf-mutator#219 which is required by Protobuf v23.
Audit logging APIs for both built-in loggers and third-party logger implementations. C++ uses using decls referring to C-Core APIs. --------- Co-authored-by: rockspore <[email protected]>
- remove the `_experimental` suffix from the gRPC policy name - remove the env var guard for the xDS policy config
… and methods in C# generated code (#32414) Apply Obsolete attribute to deprecated services and methods in C# generated code Fix for grpc/grpc#28597 - Deprecated support for enums and enum values is already fixed by protocolbuffers/protobuf#10520 but this is not yet released. It is fixed in Protocol Buffers v22.0-rc1 but the gRPC repo currently has 21.12 as the protocol buffers submodule. - Deprecated support for messages and fields already exists in the protocol buffers compiler. The fix in this PR adds `Obsolete` attribute to classes and methods for deprecated services and methods within services. e.g. ``` service Greeter { option deprecated=true; // service level deprecated // Sends a greeting rpc SayHello (HelloRequest) returns (HelloReply) { option deprecated=true; // method level deprecated } } ``` I couldn't find any protocol buffers plugin tests to update. Tested locally.
- Fix broken `bin/run_channelz.py` helper - Create `bin/run_ping_pong.py` helper that runs the baseline (aka "ping_pong") test against preconfigured infra - Setup automatic port forwarding when running `bin/run_channelz.py` and `bin/run_ping_pong.py` - Create `bin/cleanup_cluster.sh` helper to wipe xds out resources based namespaces present on the cluster Note: this involves a small change to the non-helper code, but it's just moving a the part that makes XdsTestServer/XdsTestClient instance for a given pod.
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
This can be used to disable RLS to decrease binary size, on platforms that don't disable it automatically.
Found memory access error in frame_fuzzer_test. Located the root cause in ExecCtx::Get(), where ExecCtx needs to be initialized before using HPackParser:ParseInput(). Error logs: MemorySanitizer:DEADLYSIGNAL ==2812845==ERROR: MemorySanitizer: SEGV on unknown address 0x000000000030 (pc 0x55869275574e bp 0x7fffd7d9fb50 sp 0x7fffd7d9fb20 T2812845) ==2812845==The signal is caused by a READ memory access. ==2812845==Hint: address points to the zero page. #0 0x55869275574e in starting_cpu [third_party/grpc/src/core/lib/iomgr/exec_ctx.h:129](https://cs.corp.google.com/piper///depot/google3/third_party/grpc/src/core/lib/iomgr/exec_ctx.h?l=129&ws=ladynana/2900&snapshot=42):9 #1 0x55869275574e in grpc_core::PerCpu<grpc_core::GlobalStatsCollector::Data>::this_cpu() [third_party/grpc/src/core/lib/gprpp/per_cpu.h:38](https://cs.corp.google.com/piper///depot/google3/third_party/grpc/src/core/lib/gprpp/per_cpu.h?l=38&ws=ladynana/2900&snapshot=42):48 #2 0x558692753cda in IncrementHttp2MetadataSize [third_party/grpc/src/core/lib/debug/stats_data.h:265](https://cs.corp.google.com/piper///depot/google3/third_party/grpc/src/core/lib/debug/stats_data.h?l=265&ws=ladynana/2900&snapshot=42):11 #3 0x558692753cda in grpc_core::HPackParser::ParseInput(grpc_core::HPackParser::Input, bool) [third_party/grpc/src/core/ext/transport/chttp2/transport/hpack_parser.cc:933](https://cs.corp.google.com/piper///depot/google3/third_party/grpc/src/core/ext/transport/chttp2/transport/hpack_parser.cc?l=933&ws=ladynana/2900&snapshot=42):20 <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
Added `base_namespace` experimental option to `grpc_csharp_plugin` as this has been requested several times by people not using `Grpc.Tools` to generate their code - see grpc/grpc#28663 Notes: - it should not be used with `Grpc.Tools`. That has a different way of handling duplicate proto file names in different directories. Using this option will break those builds. It can only be used on the `protoc` command line. - it uses common code with the `base_namespace` option for C# in `protoc`, which unfortunately has a slightly different name mangling algorithm for converting proto file names to C# camel case names. This only affects files with punctation or numbers in the name. This should not matter unless you are expecting specific file names - See https://protobuf.dev/reference/csharp/csharp-generated/#compiler_options for an explanation of this option
…s (#32948) Relands #32844. End2end tests will now wait for the default EventEngine to shut down between tests. This should avoid some use-after-frees and leaks.
… (#32957) Reverts grpc/grpc#32636 ``` src/compiler/csharp_generator_helpers.h:25:7: error: no member named 'compiler' in namespace ... src/compiler/csharp_generator_helpers.h:25:25: error: no member named 'csharp' in namespace 'compiler' ... ```
Sorted Community Supported platforms of C++.
…(#32968) Sanitizer issues found MSAN: https://source.cloud.google.com/results/invocations/f1667575-9397-41e9-ae8f-8560ddac9187/targets/%2F%2Ftest%2Fcore%2Fend2end:core_end2end_tests@poller%3Dpoll@experiment%3Devent_engine_listener/log ASAN: https://source.cloud.google.com/results/invocations/651d71a5-0676-4f0d-a109-531abe5d218e/targets/%2F%2Ftest%2Fcore%2Fend2end:core_end2end_tests@poller%3Depoll1@experiment%3Devent_engine_listener/log
I think `Asylo` should fall under `Community Supported` umbrella.
Try a different approach to this test and check some non-leaf functions in the returned text - looks like we're running into problems getting the leaf function out of the stack trace on that platform (which is probably fine): https://source.cloud.google.com/results/invocations/09e8e1ea-df48-4fdb-96dd-916bd5014f90/targets/%2F%2Ftest%2Fcore%2Fgprpp:examine_stack_test/tests Needed to unblock grpc/grpc#32748 <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
…004. (#32748) - Add a new docker image "rbe_ubuntu2004" that is built in a way that's analogous to how our other testing docker images are built (this gives us control over what exactly is contained in the docker image and ability to fine-tune our RBE configuration) - Switch RBE on linux to the new image (which gives us ubuntu20.04-based builds) For some reason, RBE seems to have trouble pulling the docker image from Google Artifact Registry (GAR), which is where our public testing images normally live, so for now, I used a workaround and I upload a copy of the rbe_ubuntu2004 docker image to GCR as well, and that makes RBE works just fine (see comment in the `renerate_linux_rbe_configs.sh` script). More followup items (config cleanup, getting local sanitizer builds working etc.) are in go/grpc-rbe-tech-debt-2023
…976) We need the RBAC filter name as the `policy_name` field in audit logging context.
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
This enables the feature described in [gRFC A53](https://github.com/grpc/proposal/blob/master/A53-xds-ignore-resource-deletion.md) for C2P. This also removes the now-unnecessary `xds_v3` server feature, which should have been removed as part of #31327.
Without this change, new users get this warning: ``` CMake Warning (dev) at $MY_INSTALL_DIR/lib64/cmake/protobuf/protobuf-options.cmake:6 (option): Policy CMP0077 is not set: option() honors normal variables. Run "cmake --help-policy CMP0077" for policy details. Use the cmake_policy command to set the policy and suppress this warning. For compatibility with older versions of CMake, option is clearing the normal variable 'protobuf_MODULE_COMPATIBLE'. Call Stack (most recent call first): $MY_INSTALL_DIR/lib64/cmake/protobuf/protobuf-config.cmake:2 (include) $MY_SRC_PATH/examples/cpp/cmake/common.cmake:99 (find_package) CMakeLists.txt:24 (include) This warning is for project developers. Use -Wno-dev to suppress it. ``` release notes: no <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
Add audit condition and audit logger config into `grpc_core::Rbac`.
Support translation of audit logging options from authz policy to it.
Audit logging options in authz policy looks like:
```json
{
"audit_logging_options": {
"audit_condition": "ON_DENY",
"audit_loggers": [
{
"name": "logger",
"config": {},
"is_optional": false
}
]
}
}
```
which is consistent with what's in the xDS RBAC proto but a little
flattened.
---------
Co-authored-by: rockspore <[email protected]>
…y for C++14 (#33327)" to v1.56.x (#33331) Backport grpc/grpc#33327 to v1.56.x <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Co-authored-by: Craig Tiller <[email protected]>
… with pick_first (#33347) Back-port #33336 to 1.56.
Change was created by the release automation script. See go/grpc-release.
…n (#33378) Backport of #33355 Co-authored-by: Yousuk Seung <[email protected]>
…92)" to v1.56.x (#33411) Backports grpc/grpc#33392
Change was created by the release automation script. See go/grpc-release.
Change was created by the release automation script. See go/grpc-release.
…(v1.56.x backport) (#33523) Backport of #33520 to v1.56.x. --- Follow up change of #33222. We don't want file multiple bugs if any of the sub-tests of the `url_map` test fails. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
…ver credentials. (#33583) See #33558.
Change was created by the release automation script. See go/grpc-release.
Change was created by the release automation script. See go/grpc-release.
…ptor exhaustion (#33667) Backport of #33656
PanCakes to the rescue! We noticed that our 'sanity' test was going to fail, but we think we can fix that automatically, so we put together this PR to do just that! If you'd like to opt-out of these PR's, add yourself to NO_AUTOFIX_USERS in .github/workflows/pr-auto-fix.yaml Co-authored-by: ctiller <[email protected]>
Generated by release script
…v1.56.x backport) (#33723) Backport of #33699 to v1.56.x. --- Similar to grpc/grpc-java#8982. All other languages already to this. Needed for easier deployment of grpc/grpc#33685. ref b/274944592
…rt) (#33807) Backport of #33796 to v1.56.x. --- grpc/grpc#33699 incorrectly changed the legacy builds to not just use the test driver from the master, but also to build from it. This PR fixes the issue, and also updates the python job to work use the driver from master.
*Beep boop. This is an automatically generated backport of #33738.* This should resolve breakage on master caused by the jump to Cython 3.0.0 this morning.
Update Phusion base image to address security issues. Original PR: #33847
Change was created by the release automation script. See go/grpc-release
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.