Skip to content

Commit

Permalink
Disable -ftrivial-auto-var-init= for hot code
Browse files Browse the repository at this point in the history
Improves encode_time by 10% on FullStackTest.VP9KSVC_3SL_High and other
tests when -ftrivial-auto-var-init= is used.

vp9_pick_inter_mode can be called recursevely so multiple pred_buf is
neede. So alternative to attribute should be list of bufferes in
ThreadData or TileData.

Bug: 1020220, 977230
Change-Id: I939a468f88c2b5dd2ec235de7564b92bfaa356f5
  • Loading branch information
vitalybuka committed Nov 23, 2019
1 parent 4529dc8 commit 6a3ba21
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions vp9/encoder/vp9_pickmode.c
Original file line number Diff line number Diff line change
Expand Up @@ -1719,9 +1719,9 @@ void vp9_pick_inter_mode(VP9_COMP *cpi, MACROBLOCK *x, TileDataEnc *tile_data,
// process.
// tmp[3] points to dst buffer, and the other 3 point to allocated buffers.
PRED_BUFFER tmp[4];
DECLARE_ALIGNED(16, uint8_t, pred_buf[3 * 64 * 64]);
DECLARE_ALIGNED(16, uint8_t, pred_buf[3 * 64 * 64] VPX_UNINITIALIZED);
#if CONFIG_VP9_HIGHBITDEPTH
DECLARE_ALIGNED(16, uint16_t, pred_buf_16[3 * 64 * 64]);
DECLARE_ALIGNED(16, uint16_t, pred_buf_16[3 * 64 * 64] VPX_UNINITIALIZED);
#endif
struct buf_2d orig_dst = pd->dst;
PRED_BUFFER *this_mode_pred = NULL;
Expand Down

0 comments on commit 6a3ba21

Please sign in to comment.