Shorter generated function names, unify address rendering

- Skip leading zeroes `sub_00401245` -> `sub_401245`, like IDA Pro and
  Binary Ninja
- Generate all function names and addresses from a single place
- Drive-by: Fix comparison in `HumanReadableDuration()`

PiperOrigin-RevId: 482440847
Change-Id: Ifbf59d3aa54d79a998b8a3f4d553c86201b4c4e6

call_graph.cc

@@ -17,8 +17,6 @@
 #include <cassert>
 
 #include "third_party/absl/log/log.h"
-#include "third_party/absl/strings/ascii.h"
-#include "third_party/absl/strings/escaping.h"
 #include "third_party/absl/strings/str_cat.h"
 #include "third_party/absl/strings/string_view.h"
 #include "third_party/zynamics/bindiff/flow_graph.h"
@@ -28,6 +26,7 @@
 namespace security::bindiff {
 
 using binexport::FormatAddress;
+using binexport::FormatFunctionName;
 
 namespace {
 
@@ -121,7 +120,7 @@ absl::Status CallGraph::Read(const BinExport2& proto,
     }
     if (!(vertex.flags_ & VERTEX_NAME)) {
       // Provide a dummy name for display.
-      vertex.name_ = absl::StrCat("sub_", FormatAddress(vertex.address_));
+      vertex.name_ = FormatFunctionName(vertex.address_);
     }
 
     if (proto_vertex.type() == BinExport2::CallGraph::Vertex::LIBRARY) {

call_graph.h

@@ -166,7 +166,7 @@ class CallGraph {
   void SetStub(Vertex vertex, bool stub);
 
   // Does this vertex have a real, i.e. user supplied, name? Binaries without
-  // symbols often have auto generated names like "sub_baadf00d".
+  // symbols often have auto generated names like "sub_BAADF00D".
   bool HasRealName(Vertex vertex) const;
 
   // Returns the pair<edge,true> if the edge could be found or

java/ui/src/main/java/com/google/security/zynamics/bindiff/io/BinExport2Reader.java

@@ -125,7 +125,7 @@ private static String getFunctionName(final BinExport2.CallGraph.Vertex vertex)
     if (!name.isEmpty()) {
       return name;
     }
-    return String.format("sub_%08X", vertex.getAddress());
+    return String.format("sub_%X", vertex.getAddress());
   }
 
   private static EJumpType toJumpType(final BinExport2.FlowGraph.Edge.Type type) {