Skip to content

Commit

Permalink
Fix cspell situation (rerun-io#3781)
Browse files Browse the repository at this point in the history
- Fix `cspell` not running on CI
- Disable `cspell` incremental mode
- Add a bunch of missing words
- Fix a bunch of typos

Fixes rerun-io#3723 

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3781) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/3781)
- [Docs
preview](https://rerun.io/preview/1bd451ea6623b2aceecaaeda520cc1273cdb14f3/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/1bd451ea6623b2aceecaaeda520cc1273cdb14f3/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
  • Loading branch information
teh-cmc authored Oct 10, 2023
1 parent e021608 commit 979e0ba
Show file tree
Hide file tree
Showing 9 changed files with 299 additions and 69 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/documentation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,18 @@ permissions:
contents: read

jobs:
# BEWARE(streetsidesoftware/cspell-action#187): a misconfigured cspell will _not_ have a non-zero exit code...
spellcheck:
name: Spellcheck
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: streetsidesoftware/cspell-action@v2
- uses: streetsidesoftware/cspell-action@v3
with:
config: "docs/cspell.json"
files: "**/*.md"
strict: true
incremental_files_only: false
linkinator:
name: linkinator
runs-on: ubuntu-latest
Expand Down
10 changes: 5 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ Other highlights:
- Fix row ordering flakiness when using clear APIs [#3288](https://github.com/rerun-io/rerun/pull/3288)
- Fix incorrect propagation of field's nullability into its inner list [#3352](https://github.com/rerun-io/rerun/pull/3352)
- Fix post-GC purging of streams view time histogram [#3364](https://github.com/rerun-io/rerun/pull/3364)
- Fix color greyscale colormap not being even [#3391](https://github.com/rerun-io/rerun/pull/3391)
- Fix color grayscale colormap not being even [#3391](https://github.com/rerun-io/rerun/pull/3391)
- Fix depth point cloud not taking transformation at its path into account [#3514](https://github.com/rerun-io/rerun/pull/3514)
- Fix infinite recursion when putting a container inside a viewer tab [#3534](https://github.com/rerun-io/rerun/pull/3534)
- Fix failing to preview small images [#3520](https://github.com/rerun-io/rerun/pull/3520)
Expand Down Expand Up @@ -333,7 +333,7 @@ for use-cases like real-time video feeds. [#2220](https://github.com/rerun-io/re
- Convert objectron proto.py back to using typing.List [#2559](https://github.com/rerun-io/rerun/pull/2559)
- Exclude from `objectron/proto/objectron/proto.py` from `just py-format` [#2562](https://github.com/rerun-io/rerun/pull/2562)
- Fix pinhole visualization not working with camera extrinsics & intrinsics on the same path [#2568](https://github.com/rerun-io/rerun/pull/2568)
- Fix: always auto-layout spaceviews until the user interveens [#2583](https://github.com/rerun-io/rerun/pull/2583)
- Fix: always auto-layout spaceviews until the user intervenes [#2583](https://github.com/rerun-io/rerun/pull/2583)
- Fix freeze/crash when logging large times [#2588](https://github.com/rerun-io/rerun/pull/2588)
- Update egui_tiles to fix crash [#2598](https://github.com/rerun-io/rerun/pull/2598)
- Fix clicking object with single instance (of every component) selecting instance instead of entity [#2573](https://github.com/rerun-io/rerun/pull/2573)
Expand Down Expand Up @@ -742,9 +742,9 @@ here's a smaller release packed with useful improvements 🎉
#### 🤷‍♂️ Other
- Fix secret in dispatch_lint.yml [4848f98f2605a3caf9b7695273e0871efa2d44c8](https://github.com/rerun-io/rerun/commit/4848f98f2605a3caf9b7695273e0871efa2d44c8)
- Only maintain a single manual-dispatch job for testing workflows [98f7de3b52b0fea6abe364f9d0ce0bd4c459caf1](https://github.com/rerun-io/rerun/commit/98f7de3b52b0fea6abe364f9d0ce0bd4c459caf1)
- Add other build parameterizations to manual_dispatch.yml [dbdf275eaf17220d14811dc34b69b6a76e948e73](https://github.com/rerun-io/rerun/commit/dbdf275eaf17220d14811dc34b69b6a76e948e73)
- Add other build parametrizations to manual_dispatch.yml [dbdf275eaf17220d14811dc34b69b6a76e948e73](https://github.com/rerun-io/rerun/commit/dbdf275eaf17220d14811dc34b69b6a76e948e73)
- Use proper if gates on the manual_dispatch.yml jobs [9ad62011678caaed04260ba160763e24e64a7402](https://github.com/rerun-io/rerun/commit/9ad62011678caaed04260ba160763e24e64a7402)
- Add ability to save cache to manual_disaptch.yml [5c61b37a1bc40f1a223c370b3b69b08654aada47](https://github.com/rerun-io/rerun/commit/5c61b37a1bc40f1a223c370b3b69b08654aada47)
- Add ability to save cache to manual_dispatch.yml [5c61b37a1bc40f1a223c370b3b69b08654aada47](https://github.com/rerun-io/rerun/commit/5c61b37a1bc40f1a223c370b3b69b08654aada47)
- Standard case of inputs [2729c71f1ba9f7cdbe64adc3c610caf9464324e4](https://github.com/rerun-io/rerun/commit/2729c71f1ba9f7cdbe64adc3c610caf9464324e4)
- Add manual step for packaging to 'manual_dispatch.yml' [a3178e6143c068175b477cb236f2ba2477e083ea](https://github.com/rerun-io/rerun/commit/a3178e6143c068175b477cb236f2ba2477e083ea)
- New workflow_dispatch for building wheels for a PR [3bc2cb73ece98f914254221ce0ea129015834f59](https://github.com/rerun-io/rerun/commit/3bc2cb73ece98f914254221ce0ea129015834f59)
Expand Down Expand Up @@ -907,7 +907,7 @@ This new release adds MVP support for embedding Rerun in Jupyter notebooks, and
- GPU colormapping, first step [#1835](https://github.com/rerun-io/rerun/pull/1835)
- GPU tensor colormapping [#1841](https://github.com/rerun-io/rerun/pull/1841)
- GPU picking for depth clouds [#1849](https://github.com/rerun-io/rerun/pull/1849)
- Implement billinear filtering of textures [#1850](https://github.com/rerun-io/rerun/pull/1850) [#1859](https://github.com/rerun-io/rerun/pull/1859) [#1860](https://github.com/rerun-io/rerun/pull/1860)
- Implement bilinear filtering of textures [#1850](https://github.com/rerun-io/rerun/pull/1850) [#1859](https://github.com/rerun-io/rerun/pull/1859) [#1860](https://github.com/rerun-io/rerun/pull/1860)
- Refactor: remove `GpuTexture2DHandle::invalid` [#1866](https://github.com/rerun-io/rerun/pull/1866)
- Fix filtering artifact for non-color images [#1886](https://github.com/rerun-io/rerun/pull/1886)
- Refactor: Add helper functions to `GpuTexture2DHandle` [#1900](https://github.com/rerun-io/rerun/pull/1900)
Expand Down
2 changes: 1 addition & 1 deletion design/batching.md
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,7 @@ At some point we're gonna want to have a fully dedicated storage & query path fo

Recursive clears are currently handled in `StoreDb`, which is an issue for (at least) two reasons:
- Once we start saving the store in a native format, rather than a collection of `LogMsg`, we'll lose the recursive clears when dumping then reloading the recording.
- The recursive clears aren't even arrow-ified yet.
- The recursive clears aren't even arrowified yet.

### Native file format for writing the store to disk

Expand Down
2 changes: 1 addition & 1 deletion design/blueprint_store.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ This means a trivial expression like: `rr.show(rrb.Points3D("points"))` is still

As a further simplification, the Blueprint will allow for the direct inclusion of static data, allowing users to bypass
the data-logging APIs entirely for simple use-cases that don't require temporal information. This will be accomplished
by allowing `rrb.Data` objects to be constructured from any Rerun-loggable object.
by allowing `rrb.Data` objects to be constructed from any Rerun-loggable object.

Data that is a *query* from the recording store references an entity path used seprately by the logging APIs:
```python
Expand Down
2 changes: 1 addition & 1 deletion design/component_datatypes.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ We can use this for:
### Open questions:
How do we handle Jpegs? Are they a separate datatype for the `Tensor` component: `(Tensor Jpeg)`, or are they a separate component type: `(Jpeg [u8])` ?

How do we handle the transform-graph of convertes? What if there are cycles? What if there are two different paths from one `(component datatype)` tuple to another?
How do we handle the transform-graph of conversions? What if there are cycles? What if there are two different paths from one `(component datatype)` tuple to another?

#### What naming convention should we use for datatypes?
* Rust style: `[u8]`, `[f32; 3]` etc ?
Expand Down
Loading

0 comments on commit 979e0ba

Please sign in to comment.