Skip to content

[hotfix:] Layout After New/Removed Lines #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thecoolwinter
Copy link
Contributor

@thecoolwinter thecoolwinter commented May 28, 2025

Description

Hotfix to fix mistakenly broken editing capabilities for inserting or deleting new lines.

Updates the layout pass to correctly detect new lines, and if a new one is laid out, continues to layout lines after that line.

Eg:

1
2 <- Insert "\n"
3

Before:

[visible text]
1
2 <- Layout invalidated
3 <- Layout _NOT_ invalidated, missing new line.

Now:

[visible text]
1
2 <- Layout invalidated
  <- Layout invalidated
3 <- Layout invalidated

Adds a new test case for this.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

@thecoolwinter thecoolwinter added bug Something isn't working PRIORITY labels May 28, 2025
@thecoolwinter thecoolwinter merged commit 69282e2 into CodeEditApp:main May 28, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the hotfix/new-or-removed-lines-update-layout branch May 28, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PRIORITY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant