metrics

.jshintrc

@@ -58,5 +58,5 @@
     "maxparams"     : 8,  // dang
     "maxdepth"      : 2,
     "maxstatements" : 11, // this needs to be brought down
-    "maxcomplexity" : 10 // this also needs to come down
+    "maxcomplexity" : 9 // this also needs to come down
 }

configs/testing.json

@@ -17,7 +17,7 @@
   "harbourmaster": "http://localhost:3033",
   "runnable_access_timeout": "5 seconds",
   "logExpress": false,
-  "logErrorStack": true,
+  "logErrorStack": false,
   "throwErrors": true,
   "adminToken": "e6f5a32a-4be0-4d84-91cb-782c65ae320f",
   "cleanInterval": "2 minutes",

lib/index.js

@@ -64,14 +64,17 @@ App.prototype.create = function () {
   this.server = http.createServer(app);
   return this.server;
   function errorMiddleware (err, req, res, next) {
-    if (configs.logErrorStack && false) {
-      console.log(err.stack);
-    }
+    errorHandler(err);
     res.json(err.code || 500, {
       message: err.msg || 'something bad happened :(',
       error: err.message,
-      stack: configs.logErrorStack ? err.stack : undefined
+      stack: configs.throwErrors ? err.stack : undefined
     });
+  }
+  function errorHandler (err) {
+    if (configs.logErrorStack) {
+      console.error(err.stack);
+    }
     if (err.code === 500 || err.code === undefined) {
       self.stop(function () {
         self.cleanup();

lib/rest/impexp.js

@@ -78,9 +78,9 @@ app.get('/runnables/:id/export', function (req, res) {
             runnable_json.files = [];
             async.forEach(files, function (file, cb) {
               if (file.ignore || file['default']) {
-                file.ignore = file.ignore || false;
-                file.dir = file.dir || false;
-                file['default'] = file['default'] || false;
+                file.ignore = !!file.ignore;
+                file.dir = !!file.dir;
+                file['default'] = !!file['default'];
                 runnable_json.files.push({
                   name: file.name,
                   path: file.path,

lib/rest/users.js

@@ -131,10 +131,7 @@ var getusers = function (req, res, next) {
     res.json(users);
   });
   if (req.query.ids) {
-    var userIds = req.query.ids || [];
-    if (!Array.isArray(userIds)) {
-      userIds = [userIds];
-    }
+    var userIds = [].concat(req.query.ids);
     users.publicListWithIds(req.domain, userIds, sendUsers);
   } else if (req.query.username) {
     users.publicList(req.domain, { lower_username: req.query.username.toLowerCase() }, sendUsers);