Skip to content

London | ITP-May-2025 | Sisay Mehari | Module-Data-Groups | Sprint 2 #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Sisu860
Copy link

@Sisu860 Sisu860 commented Jul 11, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist
✅ Completed Work Summary
This batch of commits includes several key improvements across object handling, function refactoring, string parsing, and utility implementations — all with input validation and test coverage.

🏠 Object Property Access & Iteration
Correctly access the houseNumber property from nested address objects.

Implemented reliable iteration over object property values for better data processing.

Fixed ingredient list logging to output correctly formatted arrays.

🔍 Utility Functions & Parsing
Added a contains function with thorough input validation and comprehensive tests.

Created createLookup function, converting arrays into lookup objects for faster access.

Improved query string parser to correctly handle multiple test cases.

📊 Counting & Frequency Functions
Implemented tally function that counts occurrences with proper parameter handling.

Refined the invert function with added tests and bug fixes for base cases.

Split calculateMode into smaller, focused functions to improve readability and maintainability.

💰 Coin Calculation Fixes
Fixed coin calculation logic by parsing coin keys safely and ignoring invalid entries.

Added tests to ensure robustness against unknown or malformed keys in input objects.

🕒 Recent Commits Highlights
Added a function to count words and return a frequency object with key-value pairs.

Completed breaking down calculateMode into smaller modular functions.

Fixed totalTill function to parse and sum coin values correctly, handling edge cases.

🧪 Testing
Full test coverage added for new and updated functions.

Tests cover edge cases, invalid inputs, and common usage scenarios to ensure reliability.

Questions
None at the moment.

@Sisu860 Sisu860 added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Participant to add when requesting review labels Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Participant to add when requesting review 📅 Sprint 2 Assigned during Sprint 2 of this module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant