Sheffield| May-2025 | Sheida Shabankari | Wireframe #464
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Page looks good!
-
There is an error in your HTML code. Can you fix the error?
-
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask ChatGPT what that requirement means).
On separate note, please do not request reviewers in all ITP PRs. Volunteers have a system to decide which PRs to review next (mainly on first come first serve basis).
There was a problem hiding this comment.
You shouldn't have changed this file. Because of your change, we cannot easily view your webpage on Netlify:
https://deploy-preview-464--cyf-onboarding-module.netlify.app/
Can you restore this file in the PR branch?
| src="https://media.licdn.com/dms/image/v2/C5112AQGaEAbx_Eykwg/article-cover_image-shrink_600_2000/article-cover_image-shrink_600_2000/0/1547385227160?e=2147483647&v=beta&t=Q_VWIG2KffRpCYdnTWg8-tSDIBj8Nchjxm1Aqj1L6i0" alt=""> | ||
| </figure> | ||
| <h2>What is the purpose of a wireframe ?</h2> | ||
| <P>The primary purpose of a wireframe is to establish the basic structure and layout of a website or application |
There was a problem hiding this comment.
It is a better practice to consistently use lowercase element name.
| visualize the user experience and identify potential issues early in the project</P> | ||
|
|
||
| <a | ||
| href="https://www.google.com/url?sa=t&source=web&rct=j&opi=89978449&url=https://balsamiq.com/learn/articles/what-are-wireframes/&ved=2ahUKEwitnYX2-ZuNAxWXSEEAHaweKq8QFnoECEEQAQ&usg=AOvVaw2zhXsFmAZrti5lc9y5sp0p">Learn |
There was a problem hiding this comment.
The destination of this URL is https://balsamiq.com/learn/articles/what-are-wireframes/? Why don't you use this URL directly?
Any reason to use URL redirection via Google in all three articles?
cjyuan
added
Reviewed
Learners, PR Template
Self checklist
Changelist
I have added 3 pictures and 3 html links .I have changed the background color.I have added border for images.align the title and footer,...
Questions
Ask any questions you have for your reviewer.