Skip to content

LONDON | MODULE-ONBOARDING | EMILIANO URUENA | SPRINT2-FORM CONTROLS #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Emilianouz
Copy link

Learners, PR Template

Self checklist

Let's write out our testable criteria. Check each one off as you complete it.

I have used HTML only.
I have not used any CSS or JavaScript.
HTML
My form is semantic html.
All inputs have associated labels.
My Lighthouse Accessibility score is 100.
I require a valid name. I have defined a valid name as a text string of two characters or more.
I require a valid email.
I require one colour from a defined set of 3 colours.
I require one size from a defined set of 6 sizes.

Changelist

Briefly explain your PR.

  • Input for the customer's name, type text min length 2 max 50.
  • Input Email addresses have a consistent pattern. Tested.
  • I created a select for colour with 3 options to sure they don't pick other colours.
  • I created 6 options radio: XS, S, M, L, XL, XXL

Copy link

netlify bot commented May 14, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 4dcfe2a
🔍 Latest deploy log https://app.netlify.com/sites/cyf-onboarding-module/deploys/68247cce3eb25b0008f54d8d
😎 Deploy Preview https://deploy-preview-473--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant