-
-
Notifications
You must be signed in to change notification settings - Fork 267
London | May-2025 | Victoria Scott | Feature/wireframe #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
London | May-2025 | Victoria Scott | Feature/wireframe #699
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation is pretty solid. Good job.
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you align the height of the images in the 2nd and 3rd articles?
-
Can you format the checked boxes using the proper Markdown syntax in your PR description so that they look something like this?
(With proper Markdown syntax, we can use mouse to check/uncheck the items)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Well done. |
Learners, PR Template
Self checklist
Changelist
Wireframe project
Questions
Ask any questions you have for your reviewer.