Skip to content

London | May-2025 | Victoria Scott | Feature/wireframe #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

VictoriaScottCodes
Copy link

@VictoriaScottCodes VictoriaScottCodes commented Jun 5, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Wireframe project

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 591d84f
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6844b946cc0fbf0008d8f84b
😎 Deploy Preview https://deploy-preview-699--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is pretty solid. Good job.

  1. According to https://validator.w3.org/, there are errors in your code. Can you fix them?

  2. When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you align the height of the images in the 2nd and 3rd articles?

  3. Can you format the checked boxes using the proper Markdown syntax in your PR description so that they look something like this?
    image
    (With proper Markdown syntax, we can use mouse to check/uncheck the items)

@cjyuan cjyuan added the Reviewed Volunteer to add when completing a review label Jun 6, 2025
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes you made in your code is pretty solid.

The checkboxes in your PR description currently look like this:
image

Can you edit them so that they look something like this?
image
(With proper Markdown syntax, we can use mouse to check/uncheck the items)

@VictoriaScottCodes VictoriaScottCodes added the Needs Review Participant to add when requesting review label Jun 7, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jun 9, 2025

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review labels Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants