Skip to content

West Midlands | ITP-May-2025 | Jonathan Boahene | Form-Control #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Abayie
Copy link

@Abayie Abayie commented Jun 7, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

This PR introduces a structured and accessible HTML form for product selection. The form collects customer identity, preferred product colour and size, and delivery date. It includes:
-Semantic structure using "section", "fieldset", and appropriate headings.
-Validated input fields for name and email with patterns and required attributes.
-Radio buttons for colour choice, dropdown for size selection, and date input for delivery.
-Form accessibility and usability enhancements (e.g., autocomplete, legend, label pairing).
This sets the foundation for collecting user preferences in a clean and organized format, ready for styling or backend integration.

Questions

To make it easier I deleted the previous PR and created this new

@Abayie Abayie added the Needs Review Participant to add when requesting review label Jun 7, 2025
@Abayie Abayie assigned Abayie and cjyuan and unassigned Abayie Jun 7, 2025
Copy link

netlify bot commented Jun 7, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 2109609
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6844a87510b26b0008ec81f2
😎 Deploy Preview https://deploy-preview-718--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (🟢 up 3 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@cjyuan
Copy link
Contributor

cjyuan commented Jun 7, 2025

Branch "fixed".

  1. Can you improve the Lighthouse Accessibility score to 100?
  2. According to https://validator.w3.org/, there is no errors but there are several warnings. Can you fix the warnings?

Note: This is a continuation of the review made in #633

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jun 7, 2025
@Abayie
Copy link
Author

Abayie commented Jun 7, 2025

On my end here lighthouse accessibility score is 100
Also as the validator only giving warnings and are no errors, I suggest we leave this at that, if I decide to implement those suggestions in this case it changes the logic of my entire form's accessibility implementation with "div's" being suggested

@cjyuan
Copy link
Contributor

cjyuan commented Jun 7, 2025

Are you referring to the Accessibility score reported by the Lighthouse tool in your browser’s DevTools, or the score shown by Netlify? If possible, could you share a screenshot of the score from your browser’s Lighthouse panel? This is what I see:
image

It's an easy fix. So I will go ahead and mark this PR as "Complete" first.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review labels Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants