London | May-2025 | Gideon Defar | Wireframe

[gideondefar]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

I used semantic HTML tags to structure the webpage and I created_ three articles, each including a title, summary, and a link also checked a webpage against a wireframe layout.

Questions

Ask any questions you have for your reviewer.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	d797428
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/684d81093429400008ff74cc
😎 Deploy Preview	https://deploy-preview-725--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[cjyuan]

Code is error-free, well-indented, clean. Implementation is solid.

To better align with the wireframe, can you

1. Replace the place holder text in the footer
2. Center the footer content
3. Ensure that the footer does not visually overlap or obscure the article content. (see pic).
   

[cjyuan]

The footer text is not yet centered, and the footer text is still obstructing the article content.
Could you address these two issues?

---

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

• Reply to their feedback.
  • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
  • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
• Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
  • Without this label, the reviewer would not know if your changes is ready to be reviewed.

[gideondefar]

The footer text is not yet centered, and the footer text is still obstructing the article content. Could you address these two issues?

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

• Reply to their feedback.

  • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
  • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.

• Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)

  • Without this label, the reviewer would not know if your changes is ready to be reviewed.

This has been fixed.

[cjyuan]

Changes look good.

[gideondefar]

Thanks for the feedback!

…

On Sat, Jun 14, 2025 at 3:36 PM CJ Yuan ***@***.***> wrote: *cjyuan* left a comment (CodeYourFuture/Module-Onboarding#725) <#725 (comment)> Changes look good. — Reply to this email directly, view it on GitHub <#725 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BR4RMV2JHXYA6T36OM53EVL3DQXN3AVCNFSM6AAAAAB7FXWXDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNZSG44TSNZQHE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>