Slideshow: Use RenderContextGl for LayerRendererGl #10169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored LayerRendererGl to utilize RenderContextGl, replacing repeated functions to reduce code duplication and improve maintainability. Signed-off-by: codewithvk <[email protected]> Change-Id: I929ca8bb65897e98a10b4efa92c068a257cd9e16
codewithvk
force-pushed
the
private/codewithvk/slideshow_improvement_new
branch
from
b50049f
to
9a558ab
Compare
eszkadev
reviewed
Oct 4, 2024
| @@ -47,10 +48,8 @@ class LayerRendererGl implements LayerRenderer { | |||
|
|
|||
| constructor(offscreenCanvas: OffscreenCanvas) { | |||
| this.offscreenCanvas = offscreenCanvas; | |||
| this.gl = this.offscreenCanvas.getContext('webgl'); | |||
| if (!this.gl) { | |||
| throw new Error('WebGL not supported'); | |||
There was a problem hiding this comment.
please leave this exception, I think we need that for detecting when to use 2d fallback
There was a problem hiding this comment.
@eszkadev I have tested, It works fine without it as we already throwing error from RenderContextGl constructor so we don't need to worry about it :)
mcecchetti
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored LayerRendererGl to utilize RenderContextGl, replacing repeated functions to reduce code duplication and improve maintainability.
Change-Id: I929ca8bb65897e98a10b4efa92c068a257cd9e16