Fewer MOBILEAPP Directive #10181
Merged
Fewer MOBILEAPP Directive #10181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ashod
commented
Oct 7, 2024
Ashod
commented
- wsd: restore performance regression due to isMobileApp
- wsd: remove ifdef MOBILEAPP
- wsd: remove ifdef MOBILEAPP
- wsd: header cleanup
- wsd: remove ifdef MOBILEAPP
Ashod
force-pushed
the
private/ash/mobile
branch
from
cb0ca00
to
d389338
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Ashod
force-pushed
the
private/ash/mobile
branch
2 times, most recently
from
016b76a
to
10467ee
Compare
caolanm
reviewed
Oct 7, 2024
Previously, mobile-app code was gated behind compiler directives, which compiled the code in and out as necessary. This was replaced by runtime conditionals. These conditionals are evaluated at runtime, which of course comes at a cost (presumably the predictor will reduce this cost in most cases). In addition, there is increased code, which wastes the hardware caches unnecessarily. Luckily, we can have the benfits of both worlds by leveraging constexpr. Now, these conditionals will be evaluated at compile-time, much like the compiler directives, restoring whatever lost performance while keeping the code clean. Change-Id: Ied55ec2a4ece6d964da4e0e2a40fbe73eec99a46 Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: Id2e3a8cee3935090eb8e9f310bb72ce659f1966d Signed-off-by: Ashod Nakashian <[email protected]>
Ashod
force-pushed
the
private/ash/mobile
branch
4 times, most recently
from
7bcb4ca
to
b6ed599
Compare
Change-Id: I2ea8895abdeb5c2de0812e9494239bc2dbbfb99a Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I7c7a425fde746bf97b833c552bdd31c8bff221ca Signed-off-by: Ashod Nakashian <[email protected]>
Ashod
force-pushed
the
private/ash/mobile
branch
from
b6ed599
to
e80c6d8
Compare
Yes, some of these can't be converted to constexpr conditionals. I'm learning the hard-way and reverting selectively. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.