feat: add additional support for datacenter editions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thx for your contribution! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Situation
The authentication for data center editions is currently not working (Error 401).
According to the Atlassian Python API, the login method changes for data center editions. Instead of username/password, the API only expects a token (The information on the documentation that this only applies to versions < 7.9 is not correct).
Changes
-on-prem-pat/-thas been added.confluence_clienthas been adjusted depending on whether the parameter-on-prem-pat/-twas set or not.Testing
Functionality has been successfully tested with Confluence data center edition 8.5.11.