fix(deploy): listLocalDeployments failing while running=true (#23)

ConduitPlatform · Jul 19, 2022 · 28d17d1 · 28d17d1
1 parent 165e35c
commit 28d17d1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -29,7 +29,7 @@ $ npm install -g @conduitplatform/cli
 $ conduit COMMAND
 running command...
 $ conduit (--version|-v)
-@conduitplatform/cli/0.0.5 linux-x64 node-v16.15.0
+@conduitplatform/cli/0.0.6 linux-x64 node-v16.15.0
 $ conduit --help [COMMAND]
 USAGE
   $ conduit COMMAND

diff --git a/src/deploy/utils.ts b/src/deploy/utils.ts
@@ -8,14 +8,18 @@ export async function listLocalDeployments(command: Command, running = false) {
   const deployments = fs.readdirSync(deploymentBasePath).filter(file => {
     return fs.statSync(path.join(deploymentBasePath, file)).isFile();
   });
+  let onlineDeployments: string[];
   if (running) {
+    onlineDeployments = [];
     for (const deployment of deployments) {
-      if (!(await Docker.getInstance().containerIsUp(`conduit-${deployment}`))) {
-        deployments.splice(deployments.indexOf(deployment));
+      if (await Docker.getInstance().containerIsUp(`conduit-${deployment}`)) {
+        onlineDeployments.push(deployment);
       }
     }
+  } else {
+    onlineDeployments = deployments;
   }
-  return deployments;
+  return onlineDeployments;
 }
 
 export function getDeploymentPaths(command: Command, tag: string) {