Disable JSON support by default #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, happy to merge, curious as to whether there's a reason for the change though? |
|
JSON support is more of an optional thing - when do we ever use it day to day? Also it slows down the build ;) |
|
I guess it's okay to disable it as long as it still gets tested ;) |
|
That would be my only concern really - OK to disable it, but "slowing down the build" probably isn't a valid reason as we'd need to test it anyway, otherwise we might as well take it out completely (and that seems a shame given we do support it). So, although it's too late now, my suggestion would be to modify this PR to enable it during the build. |
|
We are only talking about not having it on by default. Which means one less unneeded dependency and bloat for most situations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.