Skip to content

Commit

Permalink
refactor: replace cloneXXX with generics function cloneSlice
Browse files Browse the repository at this point in the history
  • Loading branch information
imroc committed Aug 5, 2023
1 parent 490ffb5 commit ec7dc7a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 22 deletions.
6 changes: 3 additions & 3 deletions client.go
Original file line number Diff line number Diff line change
Expand Up @@ -1443,9 +1443,9 @@ func (c *Client) Clone() *Client {
cc.PathParams = cloneMap(c.PathParams)
cc.QueryParams = cloneUrlValues(c.QueryParams)
cc.FormData = cloneUrlValues(c.FormData)
cc.beforeRequest = cloneRequestMiddleware(c.beforeRequest)
cc.udBeforeRequest = cloneRequestMiddleware(c.udBeforeRequest)
cc.afterResponse = cloneResponseMiddleware(c.afterResponse)
cc.beforeRequest = cloneSlice(c.beforeRequest)
cc.udBeforeRequest = cloneSlice(c.udBeforeRequest)
cc.afterResponse = cloneSlice(c.afterResponse)
cc.dumpOptions = c.dumpOptions.Clone()
cc.retryOption = c.retryOption.Clone()
return &cc
Expand Down
19 changes: 0 additions & 19 deletions req.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,25 +93,6 @@ func cloneSlice[T any](s []T) []T {
return ss
}

// TODO: change to generics function when generics are commonly used.
func cloneRequestMiddleware(m []RequestMiddleware) []RequestMiddleware {
if len(m) == 0 {
return nil
}
mm := make([]RequestMiddleware, len(m))
copy(mm, m)
return mm
}

func cloneResponseMiddleware(m []ResponseMiddleware) []ResponseMiddleware {
if len(m) == 0 {
return nil
}
mm := make([]ResponseMiddleware, len(m))
copy(mm, m)
return mm
}

func cloneUrlValues(v url.Values) url.Values {
if v == nil {
return nil
Expand Down

0 comments on commit ec7dc7a

Please sign in to comment.