Skip to content

Commit

Permalink
winc1500: nmspi: Don't force definition of USE_OLD_SPI_SW
Browse files Browse the repository at this point in the history
If this macro is forced here SPI driver code uses separate Write and
read back for bulk writes and fails doing so. If this is not defined SPI
read/write cycle is used and it perfomes successfully. This could be due
to a undocumented change in the WiFi module firmware in the newer
modules. Did not check with older module (firmware) since I did not have
them around.
Instead, we make this configurable via Kconfig on Zephyr side
and pass as a build option to this module. So that the option is
available without having to dig into the driver code.
This driver was tested along with nRF52840 and nRF52382 DK
boards and found that this define, if forced, will not work.
Two boards not working is enough to get this define moved
to Kconfig.
The corresponding changes in Zephyr are in
zephyrproject-rtos/zephyr#26907

Signed-off-by: Raja D.Singh <[email protected]>
  • Loading branch information
Raja D.Singh authored and galak committed Jan 27, 2021
1 parent 9f0a699 commit d17b7dd
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions asf/common/components/wifi/winc1500/driver/source/nmspi.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@

#ifdef CONF_WINC_USE_SPI

/* Don't force USE_OLD_SPI_SW, instead we will pass it from Zephyr side
#define USE_OLD_SPI_SW
*/

#include "bus_wrapper/include/nm_bus_wrapper.h"
#include "nmspi.h"
Expand Down

0 comments on commit d17b7dd

Please sign in to comment.