Skip to content

Commit

Permalink
fix: fix the bug of comparison of integer expressions of different si…
Browse files Browse the repository at this point in the history
…gnedness in api_server_test (4paradigm#2162)

Signed-off-by: mango <[email protected]>
  • Loading branch information
mangoGoForward authored Jul 14, 2022
1 parent 9f23989 commit 836c533
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/apiserver/api_server_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,7 @@ TEST_F(APIServerTest, getDBs) {
ASSERT_TRUE(document.HasMember("dbs"));
auto& exists_dbs = document["dbs"];
ASSERT_TRUE(exists_dbs.IsArray());
for (int i = 0; i < exists_dbs.Size(); ++i) {
for (decltype(exists_dbs.Size()) i = 0; i < exists_dbs.Size(); ++i) {
auto db = exists_dbs[i].GetString();
if (test_dbs.find(db) != test_dbs.end()) {
FAIL() << "can't have test db " << db;
Expand Down
2 changes: 1 addition & 1 deletion src/cmd/sql_cmd_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2214,7 +2214,7 @@ TEST_P(DBSDKTest, DeployStatsOnlyCollectDeployProcedure) {
env.EnableDeployStats();
absl::SleepFor(absl::Seconds(2));

for (int i =0; i < 5; ++i) {
for (int i = 0; i < 5; ++i) {
env.CallProcedure();
}

Expand Down

0 comments on commit 836c533

Please sign in to comment.