Cleanup csrlib #2923
Merged
Cleanup csrlib #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix DMTF#2908. Signed-off-by: Steven Bellock <[email protected]>
rw8896
reviewed
Dec 4, 2024
| @@ -327,7 +335,9 @@ bool libspdm_gen_csr_ex( | |||
| if (*req_csr_tracking_tag == 0) { | |||
| if (available_csr_tracking_tag == 0) { | |||
| /*no available tracking tag*/ | |||
| *req_csr_tracking_tag = 0xFF; | |||
| #if LIBSPDM_SET_CERT_CSR_PARAMS | |||
| *is_busy = true; | |||
There was a problem hiding this comment.
The comment above said "no available tracking tag" so I am confused how does this imply "device is busy".
Would you help clarify this?
There was a problem hiding this comment.
That comes from
If the Responder requires a reset to process a GET_CSR request, but does not have any available CSRTrackingTags, it shall respond with an ERROR message of ErrorCode=Busy.
|
I am OK with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2908.
This was tested with all four combination of values for
LIBSPDM_SET_CERT_CSR_PARAMSandLIBSPDM_ENABLE_CAPABILITY_CSR_CAP_EX.