Fix contrast color calculation #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisterT
reviewed
Mar 1, 2025
|
I do like the K much better, but am disappointed in the A as well, E is also slightly more legible before IMHO. |
|
It really depends on the screen. @vmcj his screen made the new A better for me |
|
I propose to also compare on Kevin his openings presentation screen. |
nickygerritsen
force-pushed
the
contrast-color
branch
from
a331bc2 to
6bcd663
Compare
|
Now with APCA standard: |
|
Beautiful 🤩 |
vmcj
approved these changes
Mar 1, 2025
nickygerritsen
force-pushed
the
contrast-color
branch
from
df067f3 to
3f87ce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
I dislike the A one, but WCAG does say black is better