Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show flags on the pre-contest page if they are enabled. #2933

Merged
merged 2 commits into from
Mar 1, 2025

Conversation

meisterT
Copy link
Member

@meisterT meisterT commented Mar 1, 2025

No description provided.

@vmcj
Copy link
Member

vmcj commented Mar 1, 2025

I think your upload of the screenshot failed.

@meisterT
Copy link
Member Author

meisterT commented Mar 1, 2025

image

@meisterT
Copy link
Member Author

meisterT commented Mar 1, 2025

Also fixed bg color now:

image

@vmcj
Copy link
Member

vmcj commented Mar 1, 2025

Not sure if I like this big color block,

Can we do it subtle in the header or with one border around the whole group?

Copy link

github-actions bot commented Mar 1, 2025

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit cf686bc. ± Comparison against base commit 81f6f44.

@meisterT
Copy link
Member Author

meisterT commented Mar 1, 2025

Not sure if I like this big color block,

Can we do it subtle in the header or with one border around the whole group?

I tried both and they also don't look great. Let's use this is as incremental improvement and improve from here.

@meisterT meisterT added this pull request to the merge queue Mar 1, 2025
Merged via the queue into DOMjudge:main with commit 945d246 Mar 1, 2025
37 checks passed
@meisterT meisterT deleted the precontestflags branch March 1, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants